upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix: test: test-syncplugin.c:plugin_register was broken

Browse source 
The variables example2com, example3com, and example4com where not
being initalised on all paths leading to Coverity issues ID 637690,
ID 637691 and ID 637692 being raised.  In addition the tests to free
them were wrong as they depended on the unintialised variables. This
has been fixed.

Closes #5598

Merge branch '5598-properly-determine-if-name-is-dynamic' into 'main'

See merge request isc-projects/bind9!11155
This commit is contained in:
Mark Andrews 2025-10-27 23:46:39 +11:00
commit b14a6935ea
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
bin/tests/system/hooks/driver/test-syncplugin.c
View file

@ -122,9 +122,9 @@ plugin_register(const char *parameters, const void *cfg, const char *cfgfile,
ns_hook_t hook;
syncplugin_t *inst = NULL;
char *sourcestr = NULL;
dns_name_t example2com;
dns_name_t example3com;
dns_name_t example4com;
dns_name_t example2com = DNS_NAME_INITEMPTY;
dns_name_t example3com = DNS_NAME_INITEMPTY;
dns_name_t example4com = DNS_NAME_INITEMPTY;
UNUSED(cfg);
UNUSED(aclctx);
@ -164,10 +164,6 @@ plugin_register(const char *parameters, const void *cfg, const char *cfgfile,
goto cleanup;
}
dns_name_init(&example2com);
dns_name_init(&example3com);
dns_name_init(&example4com);
result = dns_name_fromstring(&example2com, "example2.com.",
NULL, 0, isc_g_mctx);
result = dns_name_fromstring(&example3com, "example3.com.",
@ -201,15 +197,15 @@ plugin_register(const char *parameters, const void *cfg, const char *cfgfile,
ns_hook_add(hooktable, mctx, NS_QUERY_NXDOMAIN_BEGIN, &hook);
cleanup:
if (DNS_NAME_VALID(&example2com)) {
if (dns_name_dynamic(&example2com)) {
dns_name_free(&example2com, isc_g_mctx);
}
if (DNS_NAME_VALID(&example3com)) {
if (dns_name_dynamic(&example3com)) {
dns_name_free(&example3com, isc_g_mctx);
}
if (DNS_NAME_VALID(&example4com)) {
if (dns_name_dynamic(&example4com)) {
dns_name_free(&example4com, isc_g_mctx);
}