upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-04 20:02:05 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove workaround for ancient clang versions (<< 3.2 and << 4.0.1)

Browse source 
Some ancient versions of clang reported uninitialized memory use false
positive (see https://bugs.llvm.org/show_bug.cgi?id=14461).  Since clang
4.0.1 has been long obsoleted, just remove the workarounds.
This commit is contained in:
Ondřej Surý 2022-03-05 13:46:52 +01:00
parent 20f0936cf2
commit ae508c17bc
2 changed files with 0 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lib/dns/name.c
View file

@ -853,12 +853,6 @@ dns_name_matcheswildcard(const dns_name_t *name, const dns_name_t *wname) {
REQUIRE(labels > 0);
REQUIRE(dns_name_iswildcard(wname));
#if defined(__clang__) && \
(__clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 2))
memset(&tname, 0, sizeof(tname));
#endif /* if defined(__clang__) && (__clang_major__ < 3 || (__clang_major__ == \
* 3 \
* && __clang_minor__ < 2)) */
DNS_NAME_INIT(&tname, NULL);
dns_name_getlabelsequence(wname, 1, labels - 1, &tname);
if (dns_name_fullcompare(name, &tname, &order, &nlabels) ==
@ -1977,12 +1971,6 @@ dns_name_towire2(const dns_name_t *name, dns_compress_t *cctx,
* has one.
*/
if (name->offsets == NULL) {
#if defined(__clang__) && \
(__clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 2))
memset(&clname, 0, sizeof(clname));
#endif /* if defined(__clang__) && (__clang_major__ < 3 || (__clang_major__ == \
* 3 \
* && __clang_minor__ < 2)) */
DNS_NAME_INIT(&clname, clo);
dns_name_clone(name, &clname);
name = &clname;
@ -2300,12 +2288,6 @@ dns_name_digest(const dns_name_t *name, dns_digestfunc_t digest, void *arg) {
REQUIRE(VALID_NAME(name));
REQUIRE(digest != NULL);
#if defined(__clang__) && \
(__clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 2))
memset(&downname, 0, sizeof(downname));
#endif /* if defined(__clang__) && (__clang_major__ < 3 || (__clang_major__ == \
* 3 \
* && __clang_minor__ < 2)) */
DNS_NAME_INIT(&downname, NULL);
isc_buffer_init(&buffer, data, sizeof(data));

12
lib/dns/tsig.c
View file

@ -1145,18 +1145,6 @@ dns_tsig_verify(isc_buffer_t *source, dns_message_t *msg,
return (ret);
}
}
#if defined(__clang__) && (__clang_major__ < 3 || \
(__clang_major__ == 3 && __clang_minor__ < 2) || \
(__clang_major__ == 4 && __clang_minor__ < 2))
/* false positive: http://llvm.org/bugs/show_bug.cgi?id=14461 */
else
{
memset(&querytsig, 0, sizeof(querytsig));
}
#endif /* if defined(__clang__) && (__clang_major__ < 3 || (__clang_major__ == \
* 3 \
* && __clang_minor__ < 2) || (__clang_major__ == 4 && __clang_minor__ \
* < 2)) */
/*
* Do the key name and algorithm match that of the query?