upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix the task unit test

Browse source 
The timers can be destroyed while the timer actions are still running,
and when the action calls isc_event_free() it can assert, because it's
trying to access the destroyed timer object.

Before destroying the timers, first disable them, then wait 2 seconds
of grace period before destroying them.
This commit is contained in:
Aram Sargsyan 2025-04-01 10:46:05 +00:00
parent 24ba32450d
commit a6aee6a95e
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/isc/task_test.c
View file

@ -571,7 +571,17 @@ ISC_RUN_TEST_IMPL(basic) {
atomic_store(&done, true);
/* Let everything run for 10 seconds. */
sleep(10);
/*
* Disable the timers, let all the already dispatched events to
* complete, and then destroy the timers.
*/
(void)isc_timer_reset(ti1, isc_timertype_inactive, NULL, NULL, true);
(void)isc_timer_reset(ti2, isc_timertype_inactive, NULL, NULL, true);
(void)isc_timer_reset(ti3, isc_timertype_inactive, NULL, NULL, true);
sleep(4);
isc_timer_destroy(&ti1);
isc_timer_destroy(&ti2);
LOCK(&lock);