From a5a0dedfbcc133df054c950ed9ee4296cafc86cc Mon Sep 17 00:00:00 2001 From: Michal Nowak Date: Tue, 2 Jun 2026 14:53:25 +0000 Subject: [PATCH] Retry the key-state check in test_ksr_fast named updates the state file asynchronously; one read can race it. Assisted-by: Claude:claude-opus-4-8 --- bin/tests/system/ksr/tests_ksr.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/bin/tests/system/ksr/tests_ksr.py b/bin/tests/system/ksr/tests_ksr.py index 406250b6f1..32060acd3c 100644 --- a/bin/tests/system/ksr/tests_ksr.py +++ b/bin/tests/system/ksr/tests_ksr.py @@ -1457,8 +1457,15 @@ def test_ksr_fast(ns1): isctest.kasp.check_dnssecstatus(ns1, zone, zsks, policy=policy, verbose=True) # - dnssec_verify isctest.kasp.check_dnssec_verify(ns1, zone) + # - check keys - check_keys(zsks, lifetime, FASTCONFIG, with_state=True) + # named updates the state file asynchronously, so retry the state check + # until the rumoured -> omnipresent transition catches up. + def check_keys_state(): + check_keys(zsks, lifetime, FASTCONFIG, with_state=True) + return True + + isctest.run.retry_with_timeout(check_keys_state, timeout=30) # - check apex isctest.kasp.check_apex(ns1, zone, ksks, zsks, offline_ksk=True) # - check subdomain