upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-07-15 15:50:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

named-checkconf failed to report dnstap-output missing

Browse source 
from named.conf when dnstap was specified
This commit is contained in:
Mark Andrews 2019-07-12 14:28:03 +10:00
parent b786171423
commit a4f38bec6a
3 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CHANGES
View file

@ -1,3 +1,7 @@
5266. [bug] named-checkconf failed to report dnstap-output
missing from named.conf when dnstap was specified.
[GL #1136]
5265. [bug] DNS64 and RPZ nodata (CNAME *.) rules interacted badly
[GL #1106]

4
bin/tests/system/dnstap/bad-missing-dnstap-output.conf Normal file
View file

@ -0,0 +1,4 @@
options {
dnstap { client; auth; };
recursion yes;
};

10
lib/bind9/check.c
View file

@ -1459,6 +1459,16 @@ check_options(const cfg_obj_t *options, isc_log_t *logctx, isc_mem_t *mctx,
result = ISC_R_FAILURE;
}
}
} else {
(void) cfg_map_get(options, "dnstap", &obj);
if (obj != NULL) {
cfg_obj_log(obj, logctx, ISC_LOG_ERROR,
"'dnstap-output' must be set if 'dnstap' "
"is set");
if (result == ISC_R_SUCCESS) {
result = ISC_R_FAILURE;
}
}
}
#endif