From a35b19f80eb88457d8ce8cbaaf474bb8d6537ef3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Fri, 1 Nov 2019 08:24:35 -0500 Subject: [PATCH] libdns: dns_name_dup() can't fail, change return type to void --- lib/dns/include/dns/name.h | 2 +- lib/dns/name.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/dns/include/dns/name.h b/lib/dns/include/dns/name.h index b64092d445..6b50492491 100644 --- a/lib/dns/include/dns/name.h +++ b/lib/dns/include/dns/name.h @@ -1031,7 +1031,7 @@ dns_name_split(const dns_name_t *name, unsigned int suffixlabels, *\li #ISC_R_SUCCESS No worries. (This function should always success). */ -isc_result_t +void dns_name_dup(const dns_name_t *source, isc_mem_t *mctx, dns_name_t *target); /*%< diff --git a/lib/dns/name.c b/lib/dns/name.c index e751194478..3bb2e4fcf8 100644 --- a/lib/dns/name.c +++ b/lib/dns/name.c @@ -2159,7 +2159,7 @@ dns_name_split(const dns_name_t *name, unsigned int suffixlabels, return; } -isc_result_t +void dns_name_dup(const dns_name_t *source, isc_mem_t *mctx, dns_name_t *target) { @@ -2193,8 +2193,6 @@ dns_name_dup(const dns_name_t *source, isc_mem_t *mctx, else set_offsets(target, target->offsets, NULL); } - - return (ISC_R_SUCCESS); } isc_result_t