Use common name for post-startup server functions

Unify the names of autouse module-wide fixtures that perform
after_servers_start() setup. The consistent naming doesn't just help
readability, but also makes it simpler for the vulture exception (since
it doesn't properly deal with autouse fixtures).

(cherry picked from commit 377724c26d)

.gitlab-ci.yml

@@ -695,7 +695,7 @@ vulture:
   <<: *python_triggering_rules
   needs: []
   script:
-    - vulture --exclude "*ans.py,conftest.py,isctest" --ignore-names "bootstrap,pytestmark,reconfigure_policy,setup_filters" bin/tests/system/
+    - vulture --exclude "*ans.py,conftest.py,isctest" --ignore-names "after_servers_start,bootstrap,pytestmark" bin/tests/system/
 
 ci-variables:
   <<: *precheck_job

bin/tests/system/filters/tests_filter_a_v4.py

@@ -32,7 +32,7 @@ def bootstrap():
 
 
 @pytest.fixture(scope="module", autouse=True)
-def setup_filters():
+def after_servers_start():
     prime_cache("10.53.0.2")
     prime_cache("10.53.0.3")
 

bin/tests/system/filters/tests_filter_a_v6.py

@@ -32,7 +32,7 @@ def bootstrap():
 
 
 @pytest.fixture(scope="module", autouse=True)
-def setup_filters():
+def after_servers_start():
     prime_cache("fd92:7065:b8e:ffff::2")
     prime_cache("fd92:7065:b8e:ffff::3")
 

bin/tests/system/filters/tests_filter_aaaa_v4.py

@@ -33,7 +33,7 @@ def bootstrap():
 
 
 @pytest.fixture(scope="module", autouse=True)
-def setup_filters():
+def after_servers_start():
     prime_cache("10.53.0.2")
     prime_cache("10.53.0.3")
 

bin/tests/system/filters/tests_filter_aaaa_v6.py

@@ -32,7 +32,7 @@ def bootstrap():
 
 
 @pytest.fixture(scope="module", autouse=True)
-def setup_filters():
+def after_servers_start():
     prime_cache("fd92:7065:b8e:ffff::2")
     prime_cache("fd92:7065:b8e:ffff::3")
 

bin/tests/system/rollover-algo-csk/tests_rollover_algo_csk_reconfig.py

@@ -39,7 +39,7 @@ TIME_PASSED = 0  # set in reconfigure() fixture
 
 
 @pytest.fixture(scope="module", autouse=True)
-def reconfigure(ns6, templates):
+def after_servers_start(ns6, templates):
     global TIME_PASSED  # pylint: disable=global-statement
 
     isctest.kasp.wait_keymgr_done(ns6, "step1.csk-algorithm-roll.kasp")

bin/tests/system/rollover-algo-ksk-zsk/tests_rollover_algo_ksk_zsk_reconfig.py

@@ -39,7 +39,7 @@ TIME_PASSED = 0  # set in reconfigure() fixture
 
 
 @pytest.fixture(scope="module", autouse=True)
-def reconfigure(ns6, templates):
+def after_servers_start(ns6, templates):
     global TIME_PASSED  # pylint: disable=global-statement
 
     isctest.kasp.wait_keymgr_done(ns6, "step1.algorithm-roll.kasp")

bin/tests/system/rollover-going-insecure/tests_rollover_going_insecure_reconfig.py

@@ -26,9 +26,9 @@ from rollover.common import (
 
 
 @pytest.fixture(scope="module", autouse=True)
-def reconfigure_policy(ns6, templates):
+def after_servers_start(ns6, templates):
     templates.render("ns6/named.conf", {"policy": "insecure"})
-    ns6.reconfigure()
+    ns6.reconfigure()  # move from "unsigning" to "insecure"
 
 
 @pytest.mark.parametrize(

bin/tests/system/rollover-lifetime/tests_rollover_lifetime_reconfig.py

@@ -26,7 +26,7 @@ from rollover.common import (
 
 
 @pytest.fixture(scope="module", autouse=True)
-def reconfigure_policy(ns6, templates):
+def after_servers_start(ns6, templates):
     isctest.kasp.wait_keymgr_done(ns6, "shorter-lifetime")
     isctest.kasp.wait_keymgr_done(ns6, "longer-lifetime")
     isctest.kasp.wait_keymgr_done(ns6, "limit-lifetime")

bin/tests/system/rollover-straight2none/tests_rollver_straight2none_reconfig.py

@@ -25,7 +25,7 @@ from rollover.common import (
 
 
 @pytest.fixture(scope="module", autouse=True)
-def reconfigure_policy(ns6, templates):
+def after_servers_start(ns6, templates):
     isctest.kasp.wait_keymgr_done(ns6, "going-straight-to-none.kasp")
     isctest.kasp.wait_keymgr_done(ns6, "going-straight-to-none-dynamic.kasp")