From 6e2fbe7081b2470713ef005f840aefb45e614178 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0t=C4=9Bp=C3=A1n=20Bal=C3=A1=C5=BEik?= Date: Fri, 2 Jan 2026 19:05:33 +0100 Subject: [PATCH] Set default_aa on AsyncDnsServer to False by default In 6e684d44 I mistakenly set the default for `default_aa` for `AsyncDnsServer()` to `True` and then explicitly set it to True in cases where all the `ResponseHandlers` said `yield DnsResponseSend(..., authoritative=True)` as if the default was `False`. Also the rest of `AsyncDnsServer` code (namely `_prepare_responses`) reads like `default_aa` is `False` by default. This accidentally changed the behavior of servers which don't set the `default_aa` and where AA is not set from the zone data (e.g. `dispatch/ans3`). (cherry picked from commit dc58c7326499dab241450b8bb2c0f16df486a3e2) --- bin/tests/system/isctest/asyncserver.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/tests/system/isctest/asyncserver.py b/bin/tests/system/isctest/asyncserver.py index d2b22d7c12..849dba300a 100644 --- a/bin/tests/system/isctest/asyncserver.py +++ b/bin/tests/system/isctest/asyncserver.py @@ -822,7 +822,7 @@ class AsyncDnsServer(AsyncServer): self, /, default_rcode: dns.rcode.Rcode = dns.rcode.REFUSED, - default_aa: bool = True, + default_aa: bool = False, keyring: Union[ Dict[dns.name.Name, dns.tsig.Key], None, _NoKeyringType ] = _NoKeyringType(),