From 9cfd20cd90fab4c97fe91f68555b7a2e05b808e8 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Tue, 16 Jan 2024 14:25:27 +1100 Subject: [PATCH] Clear qctx->zversion Clear qctx->zversion when clearing qctx->zrdataset et al in lib/ns/query.c:qctx_freedata. The uncleared pointer could lead to an assertion failure if zone data needed to be re-saved which could happen with stale data support enabled. (cherry picked from commit 179fb3532ab8d4898ab070b2db54c0ce872ef709) --- lib/ns/query.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ns/query.c b/lib/ns/query.c index 37b0d0ab0d..132a151bed 100644 --- a/lib/ns/query.c +++ b/lib/ns/query.c @@ -5325,6 +5325,7 @@ qctx_freedata(query_ctx_t *qctx) { ns_client_releasename(qctx->client, &qctx->zfname); dns_db_detachnode(qctx->zdb, &qctx->znode); dns_db_detach(&qctx->zdb); + qctx->zversion = NULL; } if (qctx->event != NULL && !qctx->client->nodetach) {