From 9c24d5a16d5d252cda8af362fcbe21d7ef33f90f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Thu, 21 May 2026 11:52:56 +0200 Subject: [PATCH] Remove NoErrorHandler The NoErrorHandler class does not get matched to any query sent by ns4 in the "resend_loop" test. Remove it as it is redundant. (cherry picked from commit a296bcf587eb78b40e15cff0e8f4f4a2bd6e99e1) --- bin/tests/system/resend_loop/ans3/ans.py | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/bin/tests/system/resend_loop/ans3/ans.py b/bin/tests/system/resend_loop/ans3/ans.py index a1ee2a85c4..9a1ccf97cf 100644 --- a/bin/tests/system/resend_loop/ans3/ans.py +++ b/bin/tests/system/resend_loop/ans3/ans.py @@ -24,7 +24,6 @@ from isctest.asyncserver import ( DomainHandler, QnameQtypeHandler, QueryContext, - ResponseHandler, StaticResponseHandler, ) @@ -85,26 +84,11 @@ class CookieHandler(DomainHandler): yield DnsResponseSend(qctx.response, authoritative=True) -class NoErrorHandler(ResponseHandler): - """ - If the query is NOT a subdomain of example, respond with standard NOERROR empty answer - """ - - async def get_responses( - self, qctx: QueryContext - ) -> AsyncGenerator[DnsResponseSend, None]: - - qctx.prepare_new_response() - qctx.response.set_rcode(dns.rcode.NOERROR) - yield DnsResponseSend(qctx.response, authoritative=True) - - def resend_server() -> AsyncDnsServer: server = AsyncDnsServer(default_aa=True, default_rcode=dns.rcode.NOERROR) server.install_response_handlers( RootNSHandler(), CookieHandler(), - NoErrorHandler(), ) return server