From 96a116178567d4eb22e57aba533073de9a2f9d84 Mon Sep 17 00:00:00 2001 From: Evan Hunt Date: Thu, 2 May 2013 07:38:49 -0700 Subject: [PATCH] [master] quote table names 3563. [contrib] zone2sqlite failed with some table names. [RT #33375] --- CHANGES | 2 ++ contrib/sdb/sqlite/zone2sqlite.c | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGES b/CHANGES index 8f5c44c628..5be72cdba4 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,5 @@ +3563. [contrib] zone2sqlite failed with some table names. [RT #33375] + 3562. [func] Update map file header format to include a SHA-1 hash of the database content, so that corrupted map files can be rejected at load time. [RT #32459] diff --git a/contrib/sdb/sqlite/zone2sqlite.c b/contrib/sdb/sqlite/zone2sqlite.c index b583d2bb03..7b9260a250 100644 --- a/contrib/sdb/sqlite/zone2sqlite.c +++ b/contrib/sdb/sqlite/zone2sqlite.c @@ -129,7 +129,7 @@ addrdata(dns_name_t *name, dns_ttl_t ttl, dns_rdata_t *rdata) dataarray[isc_buffer_usedlength(&b)] = 0; sql = sqlite3_mprintf( - "INSERT INTO %q (NAME, TTL, RDTYPE, RDATA)" + "INSERT INTO %Q (NAME, TTL, RDTYPE, RDATA)" " VALUES ('%q', %d, '%q', '%q') ", dbi.table, namearray, ttl, typearray, dataarray); @@ -208,7 +208,7 @@ main(int argc, char *argv[]) closeandexit(1); } - sql = sqlite3_mprintf("DROP TABLE %q ", dbi.table); + sql = sqlite3_mprintf("DROP TABLE %Q ", dbi.table); printf("%s\n", sql); res = sqlite3_exec(dbi.db, sql, NULL, NULL, &errmsg); sqlite3_free(sql); @@ -231,7 +231,7 @@ main(int argc, char *argv[]) #endif sql = sqlite3_mprintf( - "CREATE TABLE %q " + "CREATE TABLE %Q " "(NAME TEXT, TTL INTEGER, RDTYPE TEXT, RDATA TEXT) ", dbi.table); printf("%s\n", sql);