upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-11 12:50:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

check putstr return values

Browse source 
The calls to putstr() in named_server_fetchlimit() were not checked
for failure.
This commit is contained in:
Evan Hunt 2022-07-13 16:15:53 -07:00 committed by Mark Andrews
parent 132b62614b
commit 9372baac27
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
bin/named/server.c
View file

@ -16640,10 +16640,10 @@ named_server_fetchlimit(named_server_t *server, isc_lex_t *lex,
}
if (!first) {
putstr(text, "\n");
CHECK(putstr(text, "\n"));
}
putstr(text, "Rate limited servers, view ");
putstr(text, view->name);
CHECK(putstr(text, "Rate limited servers, view "));
CHECK(putstr(text, view->name));
dns_adb_getquota(view->adb, &val, NULL, NULL, NULL, NULL);
s = snprintf(tbuf, sizeof(tbuf),
@ -16652,26 +16652,26 @@ named_server_fetchlimit(named_server_t *server, isc_lex_t *lex,
return (ISC_R_NOSPACE);
}
first = false;
putstr(text, tbuf);
CHECK(putstr(text, tbuf));
used = isc_buffer_usedlength(*text);
CHECK(dns_adb_dumpquota(view->adb, text));
if (used == isc_buffer_usedlength(*text)) {
putstr(text, "\n None.");
CHECK(putstr(text, "\n None."));
}
putstr(text, "\nRate limited servers, view ");
putstr(text, view->name);
CHECK(putstr(text, "\nRate limited servers, view "));
CHECK(putstr(text, view->name));
val = dns_resolver_getfetchesperzone(view->resolver);
s = snprintf(tbuf, sizeof(tbuf),
" (fetches-per-zone %u):", val);
if (s < 0 || (unsigned)s > sizeof(tbuf)) {
return (ISC_R_NOSPACE);
}
putstr(text, tbuf);
CHECK(putstr(text, tbuf));
used = isc_buffer_usedlength(*text);
CHECK(dns_resolver_dumpquota(view->resolver, text));
if (used == isc_buffer_usedlength(*text)) {
putstr(text, "\n None.");
CHECK(putstr(text, "\n None."));
}
}