From 930e4f52a56d501ae0deefa948d7f4b6bd5d8995 Mon Sep 17 00:00:00 2001 From: Aram Sargsyan Date: Sat, 25 Sep 2021 14:03:27 +0000 Subject: [PATCH] Fix a bug when comparing two RSA keys When comparing different parameters of two RSA keys there is a typo which causes the "p" prime factors to not being compared. Fix the typo. --- lib/dns/opensslrsa_link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dns/opensslrsa_link.c b/lib/dns/opensslrsa_link.c index f378abf420..91f6208185 100644 --- a/lib/dns/opensslrsa_link.c +++ b/lib/dns/opensslrsa_link.c @@ -406,7 +406,7 @@ opensslrsa_compare(const dst_key_t *key1, const dst_key_t *key2) { } RSA_get0_factors(rsa1, &p1, &q1); RSA_get0_factors(rsa2, &p2, &q2); - status = BN_cmp(d1, d2) || BN_cmp(p1, p1) || BN_cmp(q1, q2); + status = BN_cmp(d1, d2) || BN_cmp(p1, p2) || BN_cmp(q1, q2); if (status != 0) { return (false);