From 927dc5bc2b91116010e6a633aae4a7a1ac401efe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicki=20K=C5=99=C3=AD=C5=BEek?= Date: Tue, 8 Jul 2025 16:14:15 +0200 Subject: [PATCH] Check for FEATURETEST before running pytest When compiling with meson, it may be easy to forget to compile system test dependencies before running the tests. In that case, the test results would be quite incosistent and unpredictable, with some tests ending up with ERROR, some with FAILURE and others PASS, without a clear indication that something is off before running the entire machinery. Add a check to fail early on if the FEATURETEST binary isn't available, indicating that system test dependencies were most likely not compiled. --- bin/tests/system/conftest.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bin/tests/system/conftest.py b/bin/tests/system/conftest.py index d23a4571fc..6dfc9bed38 100644 --- a/bin/tests/system/conftest.py +++ b/bin/tests/system/conftest.py @@ -70,6 +70,10 @@ SYMLINK_REPLACEMENT_RE = re.compile(r"/tests(_.*)\.py") isctest.check.is_executable(isctest.vars.ALL["PYTHON"], "Python interpreter required") isctest.check.is_executable(isctest.vars.ALL["PERL"], "Perl interpreter required") +isctest.check.is_executable( + isctest.vars.ALL["FEATURETEST"], + "Run this first: ninja -C build system-test-dependencies", +) # --------------------------- pytest hooks -------------------------------