lib/dns/ecdb.c: Fix couple of DbC conditions reported by Cppcheck

This commit is contained in:
Ondřej Surý 2019-09-27 09:55:19 +02:00
parent fa7475b77a
commit 91cc6b9eb9

View file

@ -760,28 +760,30 @@ rdatasetiter_destroy(dns_rdatasetiter_t **iteratorp) {
static isc_result_t
rdatasetiter_first(dns_rdatasetiter_t *iterator) {
REQUIRE(DNS_RDATASETITER_VALID(iterator));
ecdb_rdatasetiter_t *ecdbiterator = (ecdb_rdatasetiter_t *)iterator;
dns_ecdbnode_t *ecdbnode = (dns_ecdbnode_t *)iterator->node;
REQUIRE(DNS_RDATASETITER_VALID(iterator));
if (ISC_LIST_EMPTY(ecdbnode->rdatasets))
if (ISC_LIST_EMPTY(ecdbnode->rdatasets)) {
return (ISC_R_NOMORE);
}
ecdbiterator->current = ISC_LIST_HEAD(ecdbnode->rdatasets);
return (ISC_R_SUCCESS);
}
static isc_result_t
rdatasetiter_next(dns_rdatasetiter_t *iterator) {
ecdb_rdatasetiter_t *ecdbiterator = (ecdb_rdatasetiter_t *)iterator;
REQUIRE(DNS_RDATASETITER_VALID(iterator));
ecdb_rdatasetiter_t *ecdbiterator = (ecdb_rdatasetiter_t *)iterator;
ecdbiterator->current = ISC_LIST_NEXT(ecdbiterator->current, link);
if (ecdbiterator->current == NULL)
if (ecdbiterator->current == NULL) {
return (ISC_R_NOMORE);
else
} else {
return (ISC_R_SUCCESS);
}
}
static void