upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-11 06:49:58 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Use a switch statement in check_recursionquota()

Browse source 
Improve readability of the check_recursionquota() function by replacing
a sequence of conditional statements with a switch statement.
This commit is contained in:
Michał Kępień 2022-06-14 13:13:32 +02:00
parent a06cdfc7b7
commit 8d64beb06f
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/ns/query.c
View file

@ -6342,27 +6342,30 @@ check_recursionquota(ns_client_t *client, ns_query_rectype_t recursion_type) {
isc_result_t result;
result = recursionquotatype_attach_soft(client, recursion_type);
if (result == ISC_R_SOFTQUOTA) {
switch (result) {
case ISC_R_SOFTQUOTA:
recursionquota_log(client, &last_soft,
"recursive-clients soft limit exceeded "
"(%u/%u/%u), aborting oldest query",
*quotap);
ns_client_killoldestquery(client);
result = ISC_R_SUCCESS;
} else if (result == ISC_R_QUOTA) {
FALLTHROUGH;
case ISC_R_SUCCESS:
break;
case ISC_R_QUOTA:
recursionquota_log(client, &last_hard,
"no more recursive clients (%u/%u/%u)",
&client->manager->sctx->recursionquota);
ns_client_killoldestquery(client);
}
if (result != ISC_R_SUCCESS) {
FALLTHROUGH;
default:
return (result);
}
dns_message_clonebuffer(client->message);
ns_client_recursing(client);
return (result);
return (ISC_R_SUCCESS);
}
isc_result_t