upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Remove 'inst != NULL' from cleanup check in plugin_register

Browse source 
'inst' is guarenteed to be non NULL at this point.

    358        *instp = inst;
    359
    360cleanup:

    CID 281450 (#2 of 2): Dereference before null check (REVERSE_INULL)
    check_after_deref: Null-checking inst suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
    361        if (result != ISC_R_SUCCESS && inst != NULL) {
    362                plugin_destroy((void **)&inst);
    363        }
    364
    365        return (result);
This commit is contained in:
Mark Andrews 2023-04-04 11:01:36 +10:00
parent d3190485b8
commit 8c5539e905
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bin/plugins/filter-a.c
View file

@ -358,7 +358,7 @@ plugin_register(const char *parameters, const void *cfg, const char *cfg_file,
*instp = inst;
cleanup:
if (result != ISC_R_SUCCESS && inst != NULL) {
if (result != ISC_R_SUCCESS) {
plugin_destroy((void **)&inst);
}

2
bin/plugins/filter-aaaa.c
View file

@ -362,7 +362,7 @@ plugin_register(const char *parameters, const void *cfg, const char *cfg_file,
*instp = inst;
cleanup:
if (result != ISC_R_SUCCESS && inst != NULL) {
if (result != ISC_R_SUCCESS) {
plugin_destroy((void **)&inst);
}