From 862f6e043a69d5e65ecd96ea2cf43000dbc21fcb Mon Sep 17 00:00:00 2001 From: Tom Krizek Date: Tue, 4 Apr 2023 10:34:37 +0200 Subject: [PATCH] Mark selected statschannel tests as xfail The test_zone_timers_secondary_json() and test_zone_timers_secondary_xml() tests are affected by issue #3983. Due to the way tests are run, they are only affected when executing them with the pytest runner. Strict mode is set for pytest runner, as it always fails there. The strict mode ensures we'll catch the change when the it starts passing once the underlying issue is fixed. It can't be set for the legacy runner, since the test (incorrectly) passes there. Related #3983 (cherry picked from commit 087a9b3c973aa503bac3598186714ced0b9ada60) --- bin/tests/system/statschannel/tests_json.py | 2 ++ bin/tests/system/statschannel/tests_xml.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/bin/tests/system/statschannel/tests_json.py b/bin/tests/system/statschannel/tests_json.py index c4599258ea..6be264f49a 100755 --- a/bin/tests/system/statschannel/tests_json.py +++ b/bin/tests/system/statschannel/tests_json.py @@ -12,6 +12,7 @@ # information regarding copyright ownership. from datetime import datetime +import os import pytest @@ -82,6 +83,7 @@ def test_zone_timers_primary_json(statsport): ) +@pytest.mark.xfail(reason="GL #3983", strict="LEGACY_TEST_RUNNER" not in os.environ) def test_zone_timers_secondary_json(statsport): generic.test_zone_timers_secondary( fetch_zones_json, diff --git a/bin/tests/system/statschannel/tests_xml.py b/bin/tests/system/statschannel/tests_xml.py index 7f0b37e846..6375d8a243 100755 --- a/bin/tests/system/statschannel/tests_xml.py +++ b/bin/tests/system/statschannel/tests_xml.py @@ -12,6 +12,7 @@ # information regarding copyright ownership. from datetime import datetime +import os import xml.etree.ElementTree as ET import pytest @@ -112,6 +113,7 @@ def test_zone_timers_primary_xml(statsport): ) +@pytest.mark.xfail(reason="GL #3983", strict="LEGACY_TEST_RUNNER" not in os.environ) def test_zone_timers_secondary_xml(statsport): generic.test_zone_timers_secondary( fetch_zones_xml,