From 8fa29c569905f0ea06d0571b555ae77233912381 Mon Sep 17 00:00:00 2001
From: Mark Andrews <marka@isc.org>
Date: Tue, 19 Jul 2022 09:57:47 +1000
Subject: [PATCH] Ensure suffix is always valid in
 bin/tests/system/qmin/ans4/ans.py

initalise suffix to ""

    170        r.answer.append(
    171            dns.rrset.from_text(
    172                lqname + suffix, 1, IN, NS, "a.bit.longer.ns.name." + suffix
    173            )
    174        )
    175        r.flags |= dns.flags.AA
           15. Condition endswith(lqname, "icky.ptang.zoop.boing."), taking true branch.
    176    elif endswith(lqname, "icky.ptang.zoop.boing."):
           CID 350722 (#7 of 7): Bad use of null-like value (FORWARD_NULL)
           16. invalid_operation: Invalid operation on null-like value suffix.
    177        r.authority.append(
    178            dns.rrset.from_text(
    179                "icky.ptang.zoop.boing." + suffix,
    180                1,
    181                IN,
    182                SOA,
    183                "ns2." + suffix + " hostmaster.arpa. 2018050100 1 1 1 1",
    184            )
    185        )

(cherry picked from commit eb798d047849aa28b0b0f14379a8e264dfa41c7f)
---
 bin/tests/system/qmin/ans4/ans.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/tests/system/qmin/ans4/ans.py b/bin/tests/system/qmin/ans4/ans.py
index a4cc13c656..f3d00c3514 100755
--- a/bin/tests/system/qmin/ans4/ans.py
+++ b/bin/tests/system/qmin/ans4/ans.py
@@ -58,6 +58,7 @@ def create_response(msg):
     qname = m.question[0].name.to_text()
     lqname = qname.lower()
     labels = lqname.split(".")
+    suffix = ""
 
     # get qtype
     rrtype = m.question[0].rdtype