upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove illogical condition from isc_buffer_reallocate that would return ISC_R_NOSPACE when requested size is less than available size

Browse source
This commit is contained in:
Ondřej Surý 2018-07-27 11:23:49 +02:00
parent 519bfe4c97
commit 7785f644c3
2 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/isc/buffer.c
View file

@ -576,9 +576,6 @@ isc_buffer_reallocate(isc_buffer_t **dynbuffer, unsigned int length) {
REQUIRE(ISC_BUFFER_VALID(*dynbuffer));
REQUIRE((*dynbuffer)->mctx != NULL);
if ((*dynbuffer)->length > length)
return (ISC_R_NOSPACE);
/*
* XXXMUKS: This is far more expensive than plain realloc() as
* it doesn't remap pages, but does ordinary copy. So is

6
lib/isc/tests/buffer_test.c
View file

@ -114,12 +114,6 @@ ATF_TC_BODY(isc_buffer_reallocate, tc) {
ATF_REQUIRE(b != NULL);
ATF_CHECK_EQ(b->length, 1024);
result = isc_buffer_reallocate(&b, 512);
ATF_CHECK_EQ(result, ISC_R_NOSPACE);
ATF_CHECK(ISC_BUFFER_VALID(b));
ATF_REQUIRE(b != NULL);
ATF_CHECK_EQ(b->length, 1024);
result = isc_buffer_reallocate(&b, 1536);
ATF_CHECK_EQ(result, ISC_R_SUCCESS);
ATF_CHECK(ISC_BUFFER_VALID(b));