From 6b6c89b3ea1100645bf026844546014e0b754cf7 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Wed, 3 Nov 2021 20:10:34 +1100 Subject: [PATCH] Silence Coverity false positive Coverity if failing to determine that 'priv.elements[i].length' is actually valid when 'buf[i]' is non-NULL. Initialise 'priv' to zeros. --- lib/dns/opensslrsa_link.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/dns/opensslrsa_link.c b/lib/dns/opensslrsa_link.c index 2edf0c98c3..34a882a3ef 100644 --- a/lib/dns/opensslrsa_link.c +++ b/lib/dns/opensslrsa_link.c @@ -790,7 +790,7 @@ err: static isc_result_t opensslrsa_tofile(const dst_key_t *key, const char *directory) { isc_result_t ret; - dst_private_t priv; + dst_private_t priv = { 0 }; unsigned char *bufs[8] = { NULL }; unsigned short i = 0; EVP_PKEY *pkey; @@ -810,7 +810,6 @@ opensslrsa_tofile(const dst_key_t *key, const char *directory) { } if (key->external) { - priv.nelements = 0; return (dst__privstruct_writefile(key, &priv, directory)); }