351. [bug] Constructing a response with rcode SERVFAIL to a TSIG

signed query could crash the server.
This commit is contained in:
Brian Wellington 2000-07-25 22:51:46 +00:00
parent 49855f0856
commit 6dc130c7c9
2 changed files with 7 additions and 2 deletions

View file

@ -1,4 +1,8 @@
351. [bug] Constructing a response with rcode SERVFAIL to a TSIG
signed query could crash the server.
block were not correctly reference counted, causing
350. [bug] Also-notify lists specified in the global options
block were not correctly reference counted, causing
a memory leak.

View file

@ -15,7 +15,7 @@
* SOFTWARE.
*/
/* $Id: message.c,v 1.135 2000/07/20 00:05:32 gson Exp $ */
/* $Id: message.c,v 1.136 2000/07/25 22:51:45 bwelling Exp $ */
/***
*** Imports
@ -442,9 +442,10 @@ msgresetsigs(dns_message_t *msg, isc_boolean_t replying) {
isc_mempool_put(msg->namepool, msg->tsigname);
msg->tsig = NULL;
msg->tsigname = NULL;
} else if (msg->querytsig != NULL) {
} else if (msg->querytsig != NULL && !replying) {
dns_rdataset_disassociate(msg->querytsig);
isc_mempool_put(msg->rdspool, msg->querytsig);
msg->querytsig = NULL;
}
if (msg->sig0 != NULL) {
INSIST(dns_rdataset_isassociated(msg->sig0));