upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-10 23:30:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Log dropped or slipped responses in the query-errors category

Browse source 
As mentioned in the comments block before the changed code block,
the dropped or slipped responses should be logged in the query
category (or rather query-errors category as done in lib/ns/client.c),
so that requests are not silently lost.

Also fix a couple of errors/typos in the code comments.

(cherry picked from commit 27e7961479)
This commit is contained in:
Aram Sargsyan 2025-06-30 13:12:09 +00:00 committed by Arаm Sаrgsyаn
parent 7a3ec8dd94
commit 6a33125d7a
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/ns/client.c
View file

@ -916,10 +916,10 @@ ns_client_error(ns_client_t *client, isc_result_t result) {
sizeof(log_buf));
if (rrl_result != DNS_RRL_RESULT_OK) {
/*
* Log dropped errors in the query category
* Log dropped errors in the query-errors category
* so that they are not lost in silence.
* Starts of rate-limited bursts are logged in
* NS_LOGCATEGORY_RRL.
* DNS_LOGCATEGORY_RRL.
*/
if (wouldlog) {
ns_client_log(client,

5
lib/ns/query.c
View file

@ -7236,7 +7236,7 @@ query_checkrrl(query_ctx_t *qctx, isc_result_t result) {
wouldlog, log_buf, sizeof(log_buf));
if (rrl_result != DNS_RRL_RESULT_OK) {
/*
* Log dropped or slipped responses in the query
* Log dropped or slipped responses in the query-errors
* category so that requests are not silently lost.
* Starts of rate-limited bursts are logged in
* DNS_LOGCATEGORY_RRL.
@ -7246,7 +7246,8 @@ query_checkrrl(query_ctx_t *qctx, isc_result_t result) {
* with other truncated responses in RespTruncated.
*/
if (wouldlog) {
ns_client_log(qctx->client, DNS_LOGCATEGORY_RRL,
ns_client_log(qctx->client,
NS_LOGCATEGORY_QUERY_ERRORS,
NS_LOGMODULE_QUERY,
DNS_RRL_LOG_DROP, "%s", log_buf);
}