diff --git a/CHANGES b/CHANGES index 708c687561..f150696946 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,9 @@ +2015. [cleanup] use-additional-cache is now acache-enable for + consistancy. Default acache-enable off in BIND 9.4 + as it requires memory usage to be configured. + It may be enabled by default in BIND 9.5 once we + have more experience with it. + 2014. [func] Statistics about acache now recorded and sent to log. [RT #15976] diff --git a/bin/named/config.c b/bin/named/config.c index 198322b794..856d2f48dd 100644 --- a/bin/named/config.c +++ b/bin/named/config.c @@ -15,7 +15,7 @@ * PERFORMANCE OF THIS SOFTWARE. */ -/* $Id: config.c,v 1.73 2006/03/09 23:21:53 marka Exp $ */ +/* $Id: config.c,v 1.74 2006/05/03 01:54:53 marka Exp $ */ /*! \file */ @@ -132,7 +132,7 @@ options {\n\ check-names slave warn;\n\ check-names response ignore;\n\ check-mx warn;\n\ - use-additional-cache true;\n\ + acache-enable no;\n\ acache-cleaning-interval 60;\n\ max-acache-size 0;\n\ dnssec-enable yes;\n\ diff --git a/bin/named/server.c b/bin/named/server.c index 94e0c0cb9f..9cab092b88 100644 --- a/bin/named/server.c +++ b/bin/named/server.c @@ -15,7 +15,7 @@ * PERFORMANCE OF THIS SOFTWARE. */ -/* $Id: server.c,v 1.462 2006/03/09 23:39:00 marka Exp $ */ +/* $Id: server.c,v 1.463 2006/05/03 01:54:53 marka Exp $ */ /*! \file */ @@ -968,11 +968,12 @@ configure_view(dns_view_t *view, const cfg_obj_t *config, /* * Create additional cache for this view and zones under the view - * unless explicitly disabled. + * if explicitly enabled. + * XXX950 default to on. */ obj = NULL; - (void)ns_config_get(maps, "use-additional-cache", &obj); - if (obj == NULL || cfg_obj_asboolean(obj)) { + (void)ns_config_get(maps, "acache-enable", &obj); + if (obj != NULL && cfg_obj_asboolean(obj)) { cmctx = NULL; CHECK(isc_mem_create(0, 0, &cmctx)); CHECK(dns_acache_create(&view->acache, cmctx, ns_g_taskmgr, diff --git a/doc/arm/Bv9ARM-book.xml b/doc/arm/Bv9ARM-book.xml index 55285f1db0..80cfd85331 100644 --- a/doc/arm/Bv9ARM-book.xml +++ b/doc/arm/Bv9ARM-book.xml @@ -18,7 +18,7 @@ - PERFORMANCE OF THIS SOFTWARE. --> - + BIND 9 Administrator Reference Manual @@ -4492,7 +4492,7 @@ category notify { null; }; root-delegation-only exclude { namelist } ; querylog yes_or_no ; disable-algorithms domain { algorithm; algorithm; }; - use-additional-cache yes_or_no ; + acache-enable yes_or_no ; acache-cleaning-interval number; max-acache-size size_spec ; clients-per-query number ; @@ -7508,7 +7508,7 @@ query-source-v6 address * port *; Thus, if the response performance does not matter and memory consumption is much more critical, the acache mechanism can be - disabled by setting use-additional-cache to + disabled by setting acache-enable to no. It is also possible to specify the upper limit of memory consumption @@ -7540,11 +7540,11 @@ query-source-v6 address * port *; - use-additional-cache + acache-enable - If yes, additional section caching is enabled. - The default value is yes. + If yes, additional section caching is + enabled. The default value is no. diff --git a/lib/isccfg/namedconf.c b/lib/isccfg/namedconf.c index a37285d703..cc34ec864c 100644 --- a/lib/isccfg/namedconf.c +++ b/lib/isccfg/namedconf.c @@ -15,7 +15,7 @@ * PERFORMANCE OF THIS SOFTWARE. */ -/* $Id: namedconf.c,v 1.68 2006/03/09 23:21:54 marka Exp $ */ +/* $Id: namedconf.c,v 1.69 2006/05/03 01:54:54 marka Exp $ */ /*! \file */ @@ -774,7 +774,7 @@ view_clauses[] = { CFG_CLAUSEFLAG_MULTI }, { "dnssec-accept-expired", &cfg_type_boolean, 0 }, { "ixfr-from-differences", &cfg_type_ixfrdifftype, 0 }, - { "use-additional-cache", &cfg_type_boolean, 0 }, + { "acache-enable", &cfg_type_boolean, 0 }, { "acache-cleaning-interval", &cfg_type_uint32, 0 }, { "max-acache-size", &cfg_type_sizenodefault, 0 }, { "clients-per-query", &cfg_type_uint32, 0 },