diff --git a/CHANGES b/CHANGES index e5a8d73fa9..ea5a51a61f 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,6 @@ +4911. [test] Improved the reliability of the 'mkeys' system test. + [GL #128] + 4910. [func] Update util/check-changes to work on release branches. [GL #113] @@ -8,7 +11,7 @@ system test. Also changed its name to allow-query. [GL #81] -4907. [test] Improved the reliabilty of the 'notify' system +4907. [test] Improved the reliability of the 'notify' system test. [GL #59] 4905. [bug] irs_resconf_load() ignored resolv.conf syntax errors diff --git a/bin/tests/system/mkeys/setup.sh b/bin/tests/system/mkeys/setup.sh index 0a7a936aab..64d0e98761 100644 --- a/bin/tests/system/mkeys/setup.sh +++ b/bin/tests/system/mkeys/setup.sh @@ -17,7 +17,6 @@ test -r $RANDFILE || $GENRANDOM 400 $RANDFILE copy_setports ns1/named1.conf.in ns1/named.conf copy_setports ns2/named.conf.in ns2/named.conf copy_setports ns3/named.conf.in ns3/named.conf -copy_setports ns4/named.conf.in ns4/named.conf copy_setports ns5/named.conf.in ns5/named.conf cp ns5/named1.args ns5/named.args diff --git a/bin/tests/system/mkeys/tests.sh b/bin/tests/system/mkeys/tests.sh index 0f1ebad8ef..b524791265 100644 --- a/bin/tests/system/mkeys/tests.sh +++ b/bin/tests/system/mkeys/tests.sh @@ -685,7 +685,7 @@ rm -f ns5/managed-keys.bind* cp ns5/named2.args ns5/named.args nextpart ns5/named.run > /dev/null $PERL $SYSTEMTESTTOP/start.pl --noclean --restart --port ${PORT} . ns5 -wait_for_log "Returned from key fetch in keyfetch_done()" ns5/named.run +wait_for_log "Returned from key fetch in keyfetch_done() for '.': failure" ns5/named.run # ns1 should still REFUSE queries from ns5, so resolving should be impossible $DIG $DIGOPTS +noauth example. @10.53.0.5 txt > dig.out.ns5.a.test$n || ret=1 grep "flags:.*ad.*QUERY" dig.out.ns5.a.test$n > /dev/null && ret=1 @@ -694,9 +694,9 @@ grep "status: SERVFAIL" dig.out.ns5.a.test$n > /dev/null || ret=1 # Allow queries from ns5 to ns1 copy_setports ns1/named3.conf.in ns1/named.conf rm -f ns1/root.db.signed.jnl -mkeys_reconfig_on 1 nextpart ns5/named.run > /dev/null -wait_for_log "Returned from key fetch in keyfetch_done()" ns5/named.run +mkeys_reconfig_on 1 +wait_for_log "Returned from key fetch in keyfetch_done() for '.': success" ns5/named.run # ns1 should not longer REFUSE queries from ns5, so managed keys should be # correctly refreshed and resolving should succeed $DIG $DIGOPTS +noauth example. @10.53.0.5 txt > dig.out.ns5.b.test$n || ret=1