From 5fa2bd7e53e1d6ee6ebcc04b0bf5f303d3e85570 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Thu, 21 May 2026 11:52:56 +0200 Subject: [PATCH] Tweak the _get_cookie() method The "len(cookie.server) == 0" condition is superfluous for the "resend_loop" system test, so remove it. Add a return type annotation to the _get_cookie() function. --- bin/tests/system/resend_loop/ans3/ans.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/bin/tests/system/resend_loop/ans3/ans.py b/bin/tests/system/resend_loop/ans3/ans.py index 2b8cf4d018..9dcdec83b5 100644 --- a/bin/tests/system/resend_loop/ans3/ans.py +++ b/bin/tests/system/resend_loop/ans3/ans.py @@ -28,13 +28,11 @@ from isctest.asyncserver import ( ) -def _get_cookie(qctx: QueryContext): +def _get_cookie(qctx: QueryContext) -> dns.edns.CookieOption | None: for o in qctx.query.options: if o.otype == dns.edns.OptionType.COOKIE: cookie = o - if len(cookie.server) == 0: - cookie.server = b"\x11\x22\x33\x44\x55\x66\x77\x88" - + cookie.server = b"\x11\x22\x33\x44\x55\x66\x77\x88" return cookie return None