upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: usr: Missing unlock

Browse source 
'kasp->lock' was not released before returning.  This could result in
named locking up if 'dns_keymgr_status' fails when 'rndc dnssec -status'
is called.

Closes #5675

Merge branch '5675-missing-unlock' into 'main'

See merge request isc-projects/bind9!11338
This commit is contained in:
Mark Andrews 2025-12-08 19:39:21 +11:00
commit 5e486a7c0a
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/dns/zone.c
View file

@ -22128,6 +22128,7 @@ isc_result_t
dns_zone_dnssecstatus(dns_zone_t *zone, dns_kasp_t *kasp,
dns_dnsseckeylist_t *keys, isc_stdtime_t now,
bool verbose, char *out, size_t out_len) {
isc_result_t result;
isc_buffer_t buf;
isc_time_t refreshkeytime;
isc_stdtime_t refresh;
@ -22152,10 +22153,10 @@ dns_zone_dnssecstatus(dns_zone_t *zone, dns_kasp_t *kasp,
bool checkds = zone->checkdstype != dns_checkdstype_no;
LOCK(&kasp->lock);
RETERR(dns_keymgr_status(kasp, keys, &buf, now, verbose, checkds));
result = dns_keymgr_status(kasp, keys, &buf, now, verbose, checkds);
UNLOCK(&kasp->lock);
return ISC_R_SUCCESS;
return result;
}
isc_result_t