From 5b4e36fbfcfa3caf53db461496dc6e94a20dd7c0 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Fri, 23 Jan 2026 13:38:16 +1100 Subject: [PATCH] Fix dsync unit test The dsync unit test was not being run and the domain names in the test data should have been fully qualified. (cherry picked from commit 2159f74a1f3b7498a59516375be928109ec847e2) --- tests/dns/rdata_test.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/tests/dns/rdata_test.c b/tests/dns/rdata_test.c index ca749b8bdd..e2777e3d72 100644 --- a/tests/dns/rdata_test.c +++ b/tests/dns/rdata_test.c @@ -1788,43 +1788,43 @@ ISC_RUN_TEST_IMPL(dsync) { /* * Known type and known scheme. */ - TEXT_VALID("CDS NOTIFY 0 example.com"), + TEXT_VALID("CDS NOTIFY 0 example.com."), /* * Known type and unknown scheme. */ - TEXT_VALID("CDS 3 0 example.com"), + TEXT_VALID("CDS 3 0 example.com."), /* * Unknown type and known scheme. */ - TEXT_VALID("TYPE1000 NOTIFY 0 example.com"), + TEXT_VALID("TYPE1000 NOTIFY 0 example.com."), /* * Unknown type and unknown scheme. */ - TEXT_VALID("TYPE1000 3 0 example.com"), + TEXT_VALID("TYPE1000 3 0 example.com."), /* * Unknown type and unknown scheme, max port. */ - TEXT_VALID("TYPE1000 3 65535 example.com"), + TEXT_VALID("TYPE1000 3 65535 example.com."), /* * Unknown type and max scheme, max port. */ - TEXT_VALID("TYPE64000 255 65535 example.com"), + TEXT_VALID("TYPE64000 255 65535 example.com."), /* * Invalid type and max scheme, max port. */ - TEXT_INVALID("INVALID 255 65536 example.com"), + TEXT_INVALID("INVALID 255 65536 example.com."), /* * Unknown type and too big scheme, max port. */ - TEXT_INVALID("TYPE1000 256 65536 example.com"), + TEXT_INVALID("TYPE1000 256 65536 example.com."), /* * Unknown type and unknown scheme, port too big. */ - TEXT_INVALID("TYPE1000 3 65536 example.com"), + TEXT_INVALID("TYPE1000 3 65536 example.com."), /* * Unknown type and bad scheme, max port. */ - TEXT_INVALID("TYPE1000 UNKNOWN 65535 example.com"), + TEXT_INVALID("TYPE1000 UNKNOWN 65535 example.com."), /* * Sentinel. */ @@ -3331,6 +3331,7 @@ ISC_TEST_ENTRY(csync) ISC_TEST_ENTRY(dnskey) ISC_TEST_ENTRY(doa) ISC_TEST_ENTRY(ds) +ISC_TEST_ENTRY(dsync) ISC_TEST_ENTRY(eid) ISC_TEST_ENTRY(hip) ISC_TEST_ENTRY(https_svcb)