upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-27 10:40:21 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Lock the address entry bucket when dumping ADB namehook

Browse source 
When dumping an ADB address entry associated with a name,
the name bucket lock was held, but the entry bucket lock was
not; this could cause data races when other threads were updating
address entry info. (These races are probably not operationally
harmful, but they triggered TSAN error reports.)

(cherry picked from commit f841f545b7)
This commit is contained in:
Evan Hunt 2022-08-11 15:06:34 -07:00
parent 1c1c0e3dca
commit 5aa4adc8e5
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/dns/adb.c
View file

@ -3675,7 +3675,13 @@ print_namehook_list(FILE *f, const char *legend, dns_adb_t *adb,
if (debug) {
fprintf(f, ";\tHook(%s) %p\n", legend, nh);
}
#ifdef __SANITIZE_THREAD__
LOCK(&adb->entrylocks[nh->entry->lock_bucket]);
#endif
dump_entry(f, adb, nh->entry, debug, now);
#ifdef __SANITIZE_THREAD__
UNLOCK(&adb->entrylocks[nh->entry->lock_bucket]);
#endif
}
}