upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-14 22:49:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

1400. [bug] Block the addition of wildcard NS records by IXFR

Browse source 
or UPDATE. [RT #3502]
developer: marka
reveiwer: ogud
This commit is contained in:
Mark Andrews 2002-11-12 20:16:30 +00:00
parent 37977368dc
commit 59ab128c97
3 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGES
View file

@ -1,3 +1,6 @@
1400. [bug] Block the addition of wildcard NS records by IXFR
or UPDATE. [RT #3502]
1399. [bug] Use serial number arithmetic when testing SIG
timestamps. [RT #4268]

10
bin/named/update.c
View file

@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: update.c,v 1.101 2002/08/29 05:40:07 marka Exp $ */
/* $Id: update.c,v 1.102 2002/11/12 20:16:30 marka Exp $ */
#include <config.h>
@ -2321,6 +2321,14 @@ update_action(isc_task_t *task, isc_event_t *event) {
typebuf);
continue;
}
if (rdata.type == dns_rdatatype_ns &&
dns_name_iswildcard(name)) {
update_log(client, zone,
LOGLEVEL_PROTOCOL,
"attempt to add wildcard NS record"
"ignored");
continue;
}
if (rdata.type == dns_rdatatype_cname) {
CHECK(cname_incompatible_rrset_exists(db, ver,
name,

5
lib/dns/xfrin.c
View file

@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: xfrin.c,v 1.130 2002/09/24 01:04:03 marka Exp $ */
/* $Id: xfrin.c,v 1.131 2002/11/12 20:16:30 marka Exp $ */
#include <config.h>
@ -510,6 +510,9 @@ xfr_rr(dns_xfrin_ctx_t *xfr, dns_name_t *name, isc_uint32_t ttl,
goto redo;
}
}
if (rdata->type == dns_rdatatype_ns &&
dns_name_iswildcard(name))
FAIL(DNS_R_INVALIDNS);
CHECK(ixfr_putdata(xfr, DNS_DIFFOP_ADD, name, ttl, rdata));
break;