upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-03 13:59:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

3861. [security] Missing isc_buffer_availablelength check results

Browse source 
in a REQUIRE assertion when printing out a packet.
                        [RT #36078]
This commit is contained in:
Mark Andrews 2014-05-25 12:39:03 +10:00
parent 4b22b8decb
commit 586d94eb74
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CHANGES
View file

@ -1,3 +1,7 @@
3861. [security] Missing isc_buffer_availablelength check results
in a REQUIRE assertion when printing out a packet.
[RT #36078]
3860. [bug] ioctl(DP_POLL) array size needs to be determined
at run time as it is limited to {OPEN_MAX}.
[RT #35878]

5
lib/dns/message.c
View file

@ -3248,7 +3248,8 @@ dns_message_pseudosectiontotext(dns_message_t *msg,
dns_pseudosection_t section,
const dns_master_style_t *style,
dns_messagetextflag_t flags,
isc_buffer_t *target) {
isc_buffer_t *target)
{
dns_rdataset_t *ps = NULL;
dns_name_t *name = NULL;
isc_result_t result;
@ -3369,6 +3370,8 @@ dns_message_pseudosectiontotext(dns_message_t *msg,
* version
*/
ADD_STRING(target, "(\"");
if (isc_buffer_availablelength(target) < optlen)
return (ISC_R_NOSPACE);
for (i = 0; i < optlen; i++) {
if (isprint(optdata[i]))
isc_buffer_putmem(target,