From 4cf2efc97a40d2883587be19530a7e253af47c9a Mon Sep 17 00:00:00 2001 From: Colin Vidal Date: Wed, 19 Nov 2025 12:32:09 +0100 Subject: [PATCH] small refactor for `max-query-restart` in `check.c` Use the `check_range_uint32()` function in `check.c` to test the boundaries of `max-query-restart` instead of custom code. --- lib/isccfg/check.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/lib/isccfg/check.c b/lib/isccfg/check.c index ca726b737f..4e690b9d99 100644 --- a/lib/isccfg/check.c +++ b/lib/isccfg/check.c @@ -1999,19 +1999,7 @@ check_options(const cfg_obj_t *options, const cfg_obj_t *config, } } - obj = NULL; - (void)cfg_map_get(options, "max-query-restarts", &obj); - if (obj != NULL) { - uint32_t restarts = cfg_obj_asuint32(obj); - if (restarts == 0 || restarts > 255) { - cfg_obj_log(obj, ISC_LOG_ERROR, - "'max-query-restarts' is out of " - "range 1..255)"); - if (result == ISC_R_SUCCESS) { - result = ISC_R_RANGE; - } - } - } + check_range_uint32(options, &result, "max-query-restarts", 1, 255); obj = NULL; (void)cfg_map_get(options, "prefetch", &obj);