From 4cb52f072e2dd8625e79d3538546a206828646ac Mon Sep 17 00:00:00 2001 From: Michal Nowak Date: Fri, 27 Sep 2024 13:38:00 +0200 Subject: [PATCH] Report expected and last returned rcode on query timeout Sometimes it's useful to see what was the server returning that did not match the expected rcode. --- bin/tests/system/isctest/query.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bin/tests/system/isctest/query.py b/bin/tests/system/isctest/query.py index 2fc1cccdfe..5662d1e380 100644 --- a/bin/tests/system/isctest/query.py +++ b/bin/tests/system/isctest/query.py @@ -48,6 +48,11 @@ def generic_query( except (dns.exception.Timeout, ConnectionRefusedError) as e: isctest.log.debug(f"{query_func.__name__}(): the '{e}' exceptio raised") time.sleep(1) + if expected_rcode is not None: + last_rcode = dns_rcode.to_text(res.rcode()) if res else None + isctest.log.debug( + f"{query_func.__name__}(): expected rcode={dns_rcode.to_text(expected_rcode)}, last rcode={last_rcode}" + ) raise dns.exception.Timeout