From 4a129256e4d3133402b508c4bbef497d7ebc72d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Fri, 27 Sep 2019 10:28:30 +0200 Subject: [PATCH] lib/dns/rbt.c: Suppress nullPointerRedundantCheck warnings from Cppcheck (cherry picked from commit 8be5c3fcfcbe7ed2dee3eaf508d0a674141636fa) --- lib/dns/rbt.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/dns/rbt.c b/lib/dns/rbt.c index dc2e8c76d4..9f5b15d199 100644 --- a/lib/dns/rbt.c +++ b/lib/dns/rbt.c @@ -2690,6 +2690,7 @@ deletefromlevel(dns_rbtnode_t *item, dns_rbtnode_t **rootp) { * Fix color violations. */ if (IS_BLACK(item)) { + /* cppcheck-suppress nullPointerRedundantCheck symbolName=item */ parent = PARENT(item); while (child != *rootp && IS_BLACK(child)) { @@ -2707,6 +2708,7 @@ deletefromlevel(dns_rbtnode_t *item, dns_rbtnode_t **rootp) { INSIST(sibling != NULL); + /* cppcheck-suppress nullPointerRedundantCheck symbolName=sibling */ if (IS_BLACK(LEFT(sibling)) && IS_BLACK(RIGHT(sibling))) { MAKE_RED(sibling); @@ -2746,6 +2748,7 @@ deletefromlevel(dns_rbtnode_t *item, dns_rbtnode_t **rootp) { INSIST(sibling != NULL); + /* cppcheck-suppress nullPointerRedundantCheck symbolName=sibling */ if (IS_BLACK(LEFT(sibling)) && IS_BLACK(RIGHT(sibling))) { MAKE_RED(sibling); @@ -2877,6 +2880,7 @@ check_properties_helper(dns_rbtnode_t *node) { return (false); } + /* cppcheck-suppress nullPointerRedundantCheck symbolName=node */ if ((DOWN(node) != NULL) && (!IS_ROOT(DOWN(node)))) return (false); @@ -2914,12 +2918,15 @@ check_black_distance_helper(dns_rbtnode_t *node, size_t *distance) { return (true); } + /* cppcheck-suppress nullPointerRedundantCheck symbolName=node */ if (!check_black_distance_helper(LEFT(node), &dl)) return (false); + /* cppcheck-suppress nullPointerRedundantCheck symbolName=node */ if (!check_black_distance_helper(RIGHT(node), &dr)) return (false); + /* cppcheck-suppress nullPointerRedundantCheck symbolName=node */ if (!check_black_distance_helper(DOWN(node), &dd)) return (false);