upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix: dev: remove deadcode in query_addbestns()

Browse source 
The local variable `zfname` was released in the cleanup part of the
function if not NULL, but it turns out it is now always NULL at that
point.

The flow can get to that part only in two cases: either `zfname` is not
NULL, and then it's ownership is moved to a different variable (thus, it
is now NULL), or `zfname` is already NULL.

Removing the bit of deadcode releasing it.

Merge branch 'colin/fix-getbestns-deadcode' into 'main'

See merge request isc-projects/bind9!11790
This commit is contained in:
Colin Vidal 2026-04-02 11:51:25 +02:00
commit 43c58dafcc
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/ns/query.c
View file

@ -10778,9 +10778,6 @@ cleanup:
if (zsigrdataset != NULL) {
ns_client_putrdataset(client, &zsigrdataset);
}
if (zfname != NULL) {
ns_client_releasename(client, &zfname);
}
dns_db_detach(&zdb);
}
}