upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-27 12:13:20 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Only call memmove if the rdata length is non zero

Browse source 
This avoids undefined behaviour on zero length rdata where the
data pointer is NULL.

(cherry picked from commit 228cc557fe)
This commit is contained in:
Mark Andrews 2024-03-13 10:15:03 +11:00
parent 0ea08e6dc0
commit 3fadd9efec
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/dns/rdataslab.c
View file

@ -320,7 +320,9 @@ dns_rdataslab_fromrdataset(dns_rdataset_t *rdataset, isc_mem_t *mctx,
? DNS_RDATASLAB_OFFLINE
: 0;
}
memmove(rawbuf, x[i].rdata.data, x[i].rdata.length);
if (x[i].rdata.length != 0) {
memmove(rawbuf, x[i].rdata.data, x[i].rdata.length);
}
rawbuf += x[i].rdata.length;
}