From dd425254a71992e63ebd9d9f576632a15a0bf423 Mon Sep 17 00:00:00 2001 From: Michal Nowak Date: Tue, 18 Aug 2020 18:27:29 +0200 Subject: [PATCH 1/2] Fix warnings in when build with --enable-buffer-useinline MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit sockaddr.c:147:49: error: pointer targets in passing argument 2 of ‘isc__buffer_putmem’ differ in signedness rdata.c:1780:30: error: pointer targets in passing argument 2 of ‘isc__buffer_putmem’ differ in signedness --- lib/dns/rdata.c | 3 ++- lib/isc/sockaddr.c | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/dns/rdata.c b/lib/dns/rdata.c index 7a281c2ef7..7bdb6498de 100644 --- a/lib/dns/rdata.c +++ b/lib/dns/rdata.c @@ -1777,7 +1777,8 @@ inet_totext(int af, uint32_t flags, isc_region_t *src, isc_buffer_t *target) { if (isc_buffer_availablelength(target) == 0) { return (ISC_R_NOSPACE); } - isc_buffer_putmem(target, "0", 1); + isc_buffer_putmem(target, (const unsigned char *)"0", + 1); } } diff --git a/lib/isc/sockaddr.c b/lib/isc/sockaddr.c index 8472739281..c01c3e65a3 100644 --- a/lib/isc/sockaddr.c +++ b/lib/isc/sockaddr.c @@ -144,7 +144,10 @@ isc_sockaddr_totext(const isc_sockaddr_t *sockaddr, isc_buffer_t *target) { return (ISC_R_NOSPACE); } - isc_buffer_putmem(target, sockaddr->type.sunix.sun_path, plen); + isc_buffer_putmem( + target, + (const unsigned char *)sockaddr->type.sunix.sun_path, + plen); /* * Null terminate after used region. From f34df4ef90c79cd13da608039c9e6519ed922377 Mon Sep 17 00:00:00 2001 From: Michal Nowak Date: Tue, 18 Aug 2020 18:30:09 +0200 Subject: [PATCH 2/2] Build CentOS 8 with --enable-buffer-useinline --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8f36a7911b..7f74f4820c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -579,7 +579,7 @@ gcc:centos8:amd64: variables: CC: gcc CFLAGS: "${CFLAGS_COMMON}" - EXTRA_CONFIGURE: "--with-libidn2" + EXTRA_CONFIGURE: "--enable-buffer-useinline --with-libidn2" <<: *centos_centos8_amd64_image <<: *build_job