upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-11 07:09:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Refactor the conditions when adding new NEGATIVE header

Browse source 
Refactor the block when adding existing negative header under common
block, so it is easier to understand that the two conditions inside are
related.
This commit is contained in:
Ondřej Surý 2025-11-08 12:09:18 +01:00
parent f4adabb2dd
commit 3d2244a745
No known key found for this signature in database
GPG key ID: 2820F37E873DEA41
1 changed files with 23 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
lib/dns/qpcache.c
View file

@ -2681,35 +2681,32 @@ add(qpcache_t *qpdb, qpcnode_t *qpnode, dns_slabheader_t *newheader,
continue;
}
if (EXISTS(newheader) && NEGATIVE(newheader) &&
rdtype == dns_rdatatype_any)
{
/*
* We're adding a negative cache entry which
* covers all types (NXDOMAIN, NODATA(QTYPE=ANY)).
*
* Make all other data ancient so that the only
* rdataset that can be found at this node is the
* negative cache entry.
*/
mark_ancient(header);
}
if (EXISTS(newheader) && NEGATIVE(newheader) &&
rdtype == dns_rdatatype_rrsig)
{
/*
* We're adding a proof that a signature doesn't exist.
*
* Mark all existing signatures as ancient.
*/
if (DNS_TYPEPAIR_TYPE(top->typepair) ==
dns_rdatatype_rrsig)
{
if (EXISTS(newheader) && NEGATIVE(newheader)) {
if (rdtype == dns_rdatatype_any) {
/*
* We're adding a negative cache entry which
* covers all types (NXDOMAIN,
* NODATA(QTYPE=ANY)).
*
* Make all other data ancient so that the only
* rdataset that can be found at this node is
* the negative cache entry.
*/
mark_ancient(header);
} else if (rdtype == dns_rdatatype_rrsig) {
/*
* We're adding a proof that a signature doesn't
* exist.
*
* Mark all existing signatures as ancient.
*/
if (DNS_TYPEPAIR_TYPE(top->typepair) ==
dns_rdatatype_rrsig)
{
mark_ancient(header);
}
}
}
if (EXISTS(newheader) && !NEGATIVE(newheader) &&
NEGATIVE(header) && EXISTS(header) && ACTIVE(header, now))
{