diff --git a/bin/tests/system/dnssec/tests.sh b/bin/tests/system/dnssec/tests.sh index 738bc6603c..56c11dcddb 100644 --- a/bin/tests/system/dnssec/tests.sh +++ b/bin/tests/system/dnssec/tests.sh @@ -3420,6 +3420,35 @@ n=$((n + 1)) test "$ret" -eq 0 || echo_i "failed" status=$((status + ret)) +echo_i "checking maximal sized compresses bit map works ($n)" +ret=0 +( + cd signer || exit 0 + key1=$(${KEYGEN} -a "${DEFAULT_ALGORITHM}" -f KSK maxcbm.example) + key2=$(${KEYGEN} -a "${DEFAULT_ALGORITHM}" maxcbm.example) + cat >>maxcbm.example.db <>maxcbm.example.db + type=$((type + 256)) + done + "${SIGNER}" -3 - -o maxcbm.example maxcbm.example.db >signer.out.$n + "${CHECKZONE}" -q -D maxcbm.example maxcbm.example.db.signed \ + | grep '^M7L6E3AJUD7LRVUMMQS595OGHBMT4DFT.*NSEC3.*TYPE65534$' >/dev/null || ret=1 +) || ret=1 +n=$((n + 1)) +if [ "$ret" -ne 0 ]; then echo_i "failed"; fi +status=$((status + ret)) + echo_i "check that 'dnssec-keygen -S' works for all supported algorithms ($n)" ret=0 alg=1 diff --git a/bin/tests/system/dnssec/tests_sh_dnssec.py b/bin/tests/system/dnssec/tests_sh_dnssec.py index 8ce5de630c..719c319130 100644 --- a/bin/tests/system/dnssec/tests_sh_dnssec.py +++ b/bin/tests/system/dnssec/tests_sh_dnssec.py @@ -166,6 +166,7 @@ pytestmark = pytest.mark.extra_artifacts( "signer/general/dsset-*", "signer/general/signed.zone", "signer/general/signer.out.*", + "signer/maxcbm.example.db", "signer/nsec3param.out", "signer/prepub.db", "signer/revoke.example.db", diff --git a/lib/dns/include/dns/nsec.h b/lib/dns/include/dns/nsec.h index e68ea35ebf..50df8e45f1 100644 --- a/lib/dns/include/dns/nsec.h +++ b/lib/dns/include/dns/nsec.h @@ -23,7 +23,12 @@ #include #include -#define DNS_NSEC_BUFFERSIZE (DNS_NAME_MAXWIRE + 8192 + 512) +/* + * max compressed bitmap size: + * 256 windows * (window number + window length + bitmap (max 256 bits)) + */ +#define DNS_NSEC_MAXCBMSIZE (256 * ((256 / 8) + 2)) +#define DNS_NSEC_BUFFERSIZE (DNS_NAME_MAXWIRE + DNS_NSEC_MAXCBMSIZE) ISC_LANG_BEGINDECLS diff --git a/lib/dns/zoneverify.c b/lib/dns/zoneverify.c index 546f0d955c..bad2e29b17 100644 --- a/lib/dns/zoneverify.c +++ b/lib/dns/zoneverify.c @@ -459,7 +459,7 @@ match_nsec3(const vctx_t *vctx, const dns_name_t *name, const unsigned char types[8192], unsigned int maxtype, const unsigned char *rawhash, size_t rhsize, isc_result_t *vresult) { - unsigned char cbm[8244]; + unsigned char cbm[DNS_NSEC_MAXCBMSIZE]; char namebuf[DNS_NAME_FORMATSIZE]; dns_rdata_nsec3_t nsec3; isc_result_t result;