upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-14 00:59:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Prevent check_stale_header() from leaking rdataset headers

Browse source 
check_stale_header() fails to update the pointer to the previous header
while processing rdataset headers eligible for serve-stale, thus
enabling rdataset headers to be leaked (i.e. disassociated from a node
and left on the relevant TTL heap) while iterating through a node.  This
can lead to several different assertion failures.  Add the missing
pointer update.
This commit is contained in:
Michał Kępień 2018-04-27 09:13:26 +02:00 committed by Evan Hunt
parent e8dd921ef9
commit 391fac1fc8
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/dns/rbtdb.c
View file

@ -4494,6 +4494,7 @@ check_stale_header(dns_rbtnode_t *node, rdatasetheader_t *header,
*/
if (KEEPSTALE(search->rbtdb) && stale > search->now) {
header->attributes |= RDATASET_ATTR_STALE;
*header_prev = header;
return ((search->options & DNS_DBFIND_STALEOK) == 0);
}