diff --git a/bin/named/server.c b/bin/named/server.c index 2cb6ba991b..28ca7dc922 100644 --- a/bin/named/server.c +++ b/bin/named/server.c @@ -14277,8 +14277,11 @@ do_modzone(named_server_t *server, ns_cfgctx_t *cfg, dns_view_t *view, #ifndef HAVE_LMDB /* Store the new zone configuration; also in NZF if applicable */ - z = UNCONST(zoneobj); - CHECK(cfg_parser_mapadd(cfg->add_parser, cfg->nzf_config, z, "zone")); + if (cfg->nzf_config != NULL) { + z = UNCONST(zoneobj); + CHECK(cfg_parser_mapadd(cfg->add_parser, cfg->nzf_config, z, + "zone")); + } #endif /* HAVE_LMDB */ if (added) { diff --git a/bin/tests/system/addzone/tests_rndc_modzone_without_add.py b/bin/tests/system/addzone/tests_rndc_modzone_without_add.py new file mode 100644 index 0000000000..3658f5f518 --- /dev/null +++ b/bin/tests/system/addzone/tests_rndc_modzone_without_add.py @@ -0,0 +1,37 @@ +# Copyright (C) Internet Systems Consortium, Inc. ("ISC") +# +# SPDX-License-Identifier: MPL-2.0 +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, you can obtain one at https://mozilla.org/MPL/2.0/. +# +# See the COPYRIGHT file distributed with this work for additional +# information regarding copyright ownership. + +import pytest + +pytestmark = pytest.mark.extra_artifacts( + [ + "ns*/*.nzf*", + "ns*/*.nzd*", + "ns1/redirect.db", + "ns2/new-zones", + "ns2/redirect.db", + "ns3/redirect.db", + ] +) + + +def test_rndc_modzone_without_add(ns3): + """ + Confirm "rndc modzone" works for a zone that was not added by "addzone". + """ + # We begin with a zone that has a normal configuration, and then modify it + # by rndc modzone. This should succeed and shouldn't cause any disruption. + # Previously, it triggered an assertion failure unless LMDB was enabled. + cmd = ns3.rndc( + 'modzone . {type primary; file "redirect.db"; allow-query {none;};};', + raise_on_exception=False, + ) + assert cmd.rc == 0