upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-11 08:09:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Always delete the cached results on broken chain

Browse source 
The logic to delete records from the cache was relying on the contents
of the validation answer.  Change the logic to always delete the
contents of the cache on the broken chain result.
This commit is contained in:
Ondřej Surý 2025-08-14 08:41:05 +02:00 committed by Evan Hunt
parent 70e99bb27a
commit 2b269fd0a4
1 changed files with 8 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
lib/dns/resolver.c
View file

@ -5289,23 +5289,19 @@ cache_rrset(fetchctx_t *fctx, isc_stdtime_t now, dns_name_t *name,
}
static void
delete_rrset(fetchctx_t *fctx, dns_name_t *name, dns_rdatatype_t type,
bool delrrsig) {
delete_rrset(fetchctx_t *fctx, dns_name_t *name, dns_rdatatype_t type) {
isc_result_t result;
dns_dbnode_t *node = NULL;
result = dns_db_findnode(fctx->cache, name, false, &node);
if (result == ISC_R_SUCCESS) {
dns_db_deleterdataset(fctx->cache, node, NULL, type, 0);
if (delrrsig) {
dns_db_deleterdataset(fctx->cache, node, NULL,
dns_rdatatype_rrsig, type);
}
if (result != ISC_R_SUCCESS) {
return;
}
if (node != NULL) {
dns_db_detachnode(&node);
}
dns_db_deleterdataset(fctx->cache, node, NULL, type, 0);
dns_db_deleterdataset(fctx->cache, node, NULL, dns_rdatatype_rrsig,
type);
dns_db_detachnode(&node);
}
static void
@ -5437,10 +5433,7 @@ validated(void *arg) {
fctx->valfail++;
result = fctx->vresult = val->result;
if (result != DNS_R_BROKENCHAIN) {
if (val->rdataset != NULL) {
delete_rrset(fctx, val->name, val->type,
val->sigrdataset != NULL);
}
delete_rrset(fctx, val->name, val->type);
} else if (!negative) {
/*
* Cache the data as pending for later validation.