From 291d05be3491f5a9f40d33ca2897d34e4d373500 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Sat, 1 Nov 2025 04:47:49 -0400 Subject: [PATCH] Fix incorrect length checks for BRID and HHIT records Fix incorrect length checks in the towire_*() methods for BRID and HHIT records to prevent assertion failures when trying to serve short records. (cherry picked from commit 14e299995f8f1dd8faeb7c5395a5a0c12b0f43f4) --- lib/dns/rdata/generic/brid_68.c | 2 +- lib/dns/rdata/generic/hhit_67.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dns/rdata/generic/brid_68.c b/lib/dns/rdata/generic/brid_68.c index 11afb16e33..ac3bbb35ae 100644 --- a/lib/dns/rdata/generic/brid_68.c +++ b/lib/dns/rdata/generic/brid_68.c @@ -85,7 +85,7 @@ fromwire_brid(ARGS_FROMWIRE) { static isc_result_t towire_brid(ARGS_TOWIRE) { REQUIRE(rdata->type == dns_rdatatype_brid); - REQUIRE(rdata->length >= 3); + REQUIRE(rdata->length > 0); UNUSED(cctx); diff --git a/lib/dns/rdata/generic/hhit_67.c b/lib/dns/rdata/generic/hhit_67.c index 8b51a82ddb..c0b57730e7 100644 --- a/lib/dns/rdata/generic/hhit_67.c +++ b/lib/dns/rdata/generic/hhit_67.c @@ -85,7 +85,7 @@ fromwire_hhit(ARGS_FROMWIRE) { static isc_result_t towire_hhit(ARGS_TOWIRE) { REQUIRE(rdata->type == dns_rdatatype_hhit); - REQUIRE(rdata->length >= 3); + REQUIRE(rdata->length > 0); UNUSED(cctx);