upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[9.20] fix: dev: Fix memory leak in dns_catz_options_setdefault() for zonedir

Browse source 
When defaults->zonedir is set, opts->zonedir is unconditionally
overwritten without freeing the previous value. This leaks memory
on every catalog zone update when zonedir defaults are configured.

Free the existing opts->zonedir before replacing it.

Backport of MR !11660

Merge branch 'backport-ondrej/fix-memory-leak-in-dns_catz_options_setdefault-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!11685
This commit is contained in:
Ondřej Surý 2026-03-14 10:56:16 +01:00
commit 1844afec7b
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/dns/catz.c
View file

@ -225,6 +225,9 @@ dns_catz_options_setdefault(isc_mem_t *mctx, const dns_catz_options_t *defaults,
}
if (defaults->zonedir != NULL) {
if (opts->zonedir != NULL) {
isc_mem_free(mctx, opts->zonedir);
}
opts->zonedir = isc_mem_strdup(mctx, defaults->zonedir);
}