From 17e5c2a50e693b7f01eddad4f8bdd4828d1050ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Wed, 28 Apr 2021 07:56:47 +0200 Subject: [PATCH] Prevent useless logging in the "tcp" system test The regression test for CVE-2020-8620 causes a lot of useless messages to be logged. However, globally decreasing the log level for the affected named instance would be a step too far as debugging information may be useful for troubleshooting other checks in the "tcp" system test. Starting a separate named instance for a single check should be avoided when possible and thus is also not a good solution. As a compromise, run "rndc trace 1" for the affected named instance before starting the regression test for CVE-2020-8620. --- bin/tests/system/tcp/tests.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/bin/tests/system/tcp/tests.sh b/bin/tests/system/tcp/tests.sh index 6074427c6f..4faadaa1cb 100644 --- a/bin/tests/system/tcp/tests.sh +++ b/bin/tests/system/tcp/tests.sh @@ -183,9 +183,15 @@ grep "status: NXDOMAIN" dig.out.test$n > /dev/null || ret=1 if [ $ret != 0 ]; then echo_i "failed"; fi status=$((status + ret)) +#################################################### +# NOTE: The next test resets the debug level to 1. # +#################################################### + n=$((n + 1)) echo_i "checking that BIND 9 doesn't crash on long TCP messages ($n)" ret=0 +# Avoid logging useless information. +rndccmd 10.53.0.1 trace 1 || ret=1 { $PERL ../packet.pl -a "10.53.0.1" -p "${PORT}" -t tcp -r 300000 1996-alloc_dnsbuf-crash-test.pkt || ret=1 ; } | cat_i dig_with_opts +tcp @10.53.0.1 txt.example > dig.out.test$n || ret=1 if [ $ret != 0 ]; then echo_i "failed"; fi