upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-11 04:50:01 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Use 32-bit hashing in isc memory debugging

Browse source 
Switch from 64-bit isc_hash_function() to 32-bit isc_hash32() as we were
using the 32-bit value only anyway.
This commit is contained in:
Ondřej Surý 2023-09-12 16:35:29 +02:00
parent 9d326aaba3
commit 1653fa61c7
No known key found for this signature in database
GPG key ID: 2820F37E873DEA41
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/isc/mem.c
View file

@ -216,11 +216,11 @@ add_trace_entry(isc_mem_t *mctx, const void *ptr, size_t size FLARG) {
#ifdef __COVERITY__
/*
* Use simple conversion from pointer to hash to avoid
* tainting 'ptr' due to byte swap in isc_hash_function.
* tainting 'ptr' due to byte swap in isc_hash32.
*/
hash = (uintptr_t)ptr >> 3;
#else
hash = isc_hash_function(&ptr, sizeof(ptr), true);
hash = isc_hash32(&ptr, sizeof(ptr), true);
#endif
idx = hash % DEBUG_TABLE_COUNT;
@ -260,11 +260,11 @@ delete_trace_entry(isc_mem_t *mctx, const void *ptr, size_t size,
#ifdef __COVERITY__
/*
* Use simple conversion from pointer to hash to avoid
* tainting 'ptr' due to byte swap in isc_hash_function.
* tainting 'ptr' due to byte swap in isc_hash32.
*/
hash = (uintptr_t)ptr >> 3;
#else
hash = isc_hash_function(&ptr, sizeof(ptr), true);
hash = isc_hash32(&ptr, sizeof(ptr), true);
#endif
idx = hash % DEBUG_TABLE_COUNT;