From a730bc47f5aae9cf43a75db0dce29acb91d040b6 Mon Sep 17 00:00:00 2001 From: Michal Nowak Date: Mon, 19 Oct 2020 16:01:42 +0200 Subject: [PATCH 1/2] Add ThreadSanitizer core dumping flags This should let us have core dumps from crashed system test when ThreadSanitizer is enabled. --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index a8549f644c..2a6311230e 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -22,7 +22,7 @@ variables: # Pass run-time flags to AddressSanitizer to get core dumps on error. ASAN_OPTIONS_COMMON: abort_on_error=1:disable_coredump=0:unmap_shadow_on_exit=1 - TSAN_OPTIONS_COMMON: "second_deadlock_stack=1 history_size=7 log_exe_name=true log_path=tsan external_symbolizer_path=/usr/lib/llvm-11/bin/llvm-symbolizer" + TSAN_OPTIONS_COMMON: "disable_coredump=0 second_deadlock_stack=1 history_size=7 log_exe_name=true log_path=tsan external_symbolizer_path=/usr/lib/llvm-11/bin/llvm-symbolizer" TARBALL_EXTENSION: xz From 4072cc2b9328a7c888bd90d96c178ea4b8b3bbc6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Thu, 4 Mar 2021 15:21:28 +0100 Subject: [PATCH 2/2] Disable allow_failure for ThreadSanitizer jobs Since the main branch is now TSAN-clean, it's a good opportunity to enable hard failures for the TSAN system test jobs. --- .gitlab-ci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2a6311230e..7de6c7664b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -334,7 +334,6 @@ stages: .system_test_tsan: &system_test_tsan_job <<: *system_test_common - allow_failure: true after_script: - cat bin/tests/system/test-suite.log - find bin -name 'tsan.*' -exec python3 util/parse_tsan.py {} \;