From 123a3dddc94534d3a6c6f81c118a5b63dc5994c3 Mon Sep 17 00:00:00 2001 From: Andreas Gustafsson Date: Wed, 7 Mar 2001 22:30:21 +0000 Subject: [PATCH] 772. [bug] Owner names could be incorrectly omitted from cache dumps in the presence of negative caching entries. [RT #991] --- CHANGES | 5 +++++ lib/dns/masterdump.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGES b/CHANGES index 93df041290..44702017ef 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,8 @@ + + 772. [bug] Owner names could be incorrectly omitted from cache + dumps in the presence of negative caching entries. + [RT #991] + 771. [cleanup] TSIG errors related to unsynchronized clocks are logged better. diff --git a/lib/dns/masterdump.c b/lib/dns/masterdump.c index bfd13ad1a4..38050d7d78 100644 --- a/lib/dns/masterdump.c +++ b/lib/dns/masterdump.c @@ -15,7 +15,7 @@ * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ -/* $Id: masterdump.c,v 1.44 2001/01/16 21:18:10 gson Exp $ */ +/* $Id: masterdump.c,v 1.45 2001/03/07 22:30:21 gson Exp $ */ #include @@ -737,10 +737,10 @@ dump_rdatasets(isc_mem_t *mctx, dns_name_t *name, dns_rdatasetiter_t *rdsiter, buffer, f); if (result != ISC_R_SUCCESS) dumpresult = result; + if ((ctx->style.flags & DNS_STYLEFLAG_OMIT_OWNER) != 0) + name = NULL; } dns_rdataset_disassociate(sorted[i]); - if ((ctx->style.flags & DNS_STYLEFLAG_OMIT_OWNER) != 0) - name = NULL; } if (dumpresult != ISC_R_SUCCESS)