upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch '239-don-t-use-null-as-a-argument-to-a-varargs-function-as-it-may-not-be-promoted-properly' into 'master'

Browse source 
Resolve "don't use NULL as a argument to a varargs function as it may not be promoted properly"

Closes #239

See merge request isc-projects/bind9!228
This commit is contained in:
Michał Kępień 2018-05-11 02:20:43 -04:00
commit 0ea363746e
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGES
View file

@ -1,3 +1,6 @@
4944. [cleanup] Silence cppcheck portability warnings in
lib/isc/tests/buffer_test.c. [GL #239]
4943. [bug] Change 4687 consumed too much memory when running
system tests with --with-tuning=large. Reduced the
hash table size to 512 entries for 'named -m record'

7
lib/isc/tests/buffer_test.c
View file

@ -265,10 +265,15 @@ ATF_TC_BODY(isc_buffer_printf, tc) {
/*
* Check an empty format string is properly handled.
*
* Note: we don't use a string literal for the format string to
* avoid triggering [-Werror=format-zero-length].
* Note: we have a dummy third argument as some compilers complain
* without it.
*/
prev_used = used;
empty_fmt = "";
result = isc_buffer_printf(b, empty_fmt, NULL);
result = isc_buffer_printf(b, empty_fmt, "");
ATF_CHECK_EQ(result, ISC_R_SUCCESS);
used = isc_buffer_usedlength(b);
ATF_CHECK_EQ(prev_used, used);