Merge branch '3670-bump-statschannel-headers-v9_18' into 'v9_18'

Bump the allowed HTTP headers in statschannel to 100 [v9.18]

See merge request isc-projects/bind9!7071

CHANGES

@@ -1,3 +1,7 @@
+6015.	[bug]		Some browsers (Firefox) send more than 10 HTTP
+			headers.  Bump the number of allowed HTTP headers
+			to 100. [GL #3670]
+
 6013.	[bug]		Fix a crash that could happen when you change
 			a dnssec-policy zone with NSEC3 to start using
 			inline-signing. [GL #3591]

bin/tests/system/statschannel/tests.sh

@@ -432,13 +432,13 @@ if [ -x "${CURL}" ] && ! ("${CURL}" --next 2>&1 | grep 'option --next: is unknow
     CURL_NEXT="${CURL}"
 fi
 
-echo_i "Check HTTP with more than 10 headers ($n)"
+echo_i "Check HTTP with more than 100 headers ($n)"
 ret=0
 i=0
 if [ -x "${CURL_NEXT}" ] ; then
     # build input stream.
     : > header.in$n
-    while test $i -lt 11
+    while test $i -lt 101
     do
         printf 'X-Bloat%d: VGhlIG1vc3QgY29tbW9uIHJlYXNvbiBmb3IgYmxvYXRpbmcgaXMgaGF2aW5nIGEgbG90IG9mIGdhcyBpbiB5b3VyIGd1dC4gCg==\r\n' $i >> header.in$n
         i=$((i+1))

doc/notes/notes-current.rst

@@ -35,7 +35,9 @@ Feature Changes
 Bug Fixes
 ~~~~~~~~~
 
-- None.
+- Increase the number of HTTP headers in the statistics channel from
+  10 to 100 to accomodate for some browsers that send more that 10
+  headers by default. :gl:`#3670`
 
 Known Issues
 ~~~~~~~~~~~~

lib/isc/httpd.c

@@ -51,7 +51,7 @@
  */
 #define HTTP_RECVLEN	     ISC_NETMGR_TCP_RECVBUF_SIZE * 2
 #define HTTP_SENDLEN	     ISC_NETMGR_TCP_RECVBUF_SIZE
-#define HTTP_HEADERS_NUM     10
+#define HTTP_HEADERS_NUM     100
 #define HTTP_MAX_REQUEST_LEN 4096
 
 #define HTTPD_CLOSE	     0x0001 /* Got a Connection: close header */